Hi Ryan,
Thanks for the contribution.
Any reason you see why we shouldn't load the bootstrap assets off a CDN?
Maybe we should have this as the default behaviour
Lior

On Sun, Apr 20, 2014 at 8:22 AM, Ryan Latham notifications@github.comwrote:

... will move the glyphicon fonts, from the default bootstrap dist
directory, into the public/build/ directory. The bootstrap.min.css file
expects the fonts to be in this directory and will cause 404 errors on
heroku if they are not present. The copy task has been added the list of
tasks run on a heroku production build. If bootstrap is ever served using a
CDN, this change should be removed.

Closes #410 #410

You can merge this Pull Request by running

git pull https://github.com/ryanlatham/mean heroku-glyphicons-fix

Or view, comment on, or merge it at:

#412
Commit Summary

• Added the grunt-contrib-copy package and associated copy task. This
  task will move the glyphicon fonts, from the default bootstap dist
  directory, into the public/build/ directory. The bootstrap.min.css file
  expects the fonts to be in this directory and will cause 404 errors on
  heroku if they are not present. The copy task has been added the list of
  tasks run on a heroku production build. If bootstrap is ever served using a
  CDN, this change should be removed.

File Changes

• M Gruntfile.jshttps://github.com/Added the grunt-contrib-copy package and associated copy task. This task... #412/files#diff-0(7)
• M package.jsonhttps://github.com/Added the grunt-contrib-copy package and associated copy task. This task... #412/files#diff-1(1)
• M server/config/assets.jsonhttps://github.com/Added the grunt-contrib-copy package and associated copy task. This task... #412/files#diff-2(12)

Patch Links:

• https://github.com/linnovate/mean/pull/412.patch
• https://github.com/linnovate/mean/pull/412.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/412
.

Lior Kesos - http://www.linnovate.net
Linnovate - Community Infrastructure Care
mail: lior@linnovate.net
office: +972 722500881
cell: +972 524305252
skype: liorkesos

Hi Lior,

No, actually I don't see any practical reason why bootstrap shouldn't be served off a CDN. Doing so increases the speed at which your pages load, decreases load on your own hosting platform, reduces the need to manually manage files (like I had to do in this PR), and I believe is the generally accepted standard for serving static assets. In addition, if the user has already visited a website that used a CDN to deliver the same assets that you are delivering, the browser will use the cached version, completely eliminating the need to redownload them.

My only opposition to CDNs is a moral one. The reason most CDNs are free is the CDN hosters record data on anyone that makes a request. Therefore, anyone who visits your website is inadvertently also visiting your CDN's websites. I dislike the lack of transparency. However, I still think using a CDN is a best a practice at this point.

I had not mentioned the CDN fix because I saw there was some opposition to in in #291. If you are open to exploring this route though, I would be willing to be remove my changes and test out @udisun's changes to see if they resolved this issue.

Ryan

@ryanlatham @liorkesos any reason we shouldn't merge this PR now to fix the glyphicon problem until we sort out the CDN stuff?

@fyockm @liorkesos I would think it was a good idea for now. I have been contacted by other users who tried out these changes and have verified they are working. This at least puts you in a functional state until a better solution can be found.

@ryanlatham what happened to the repo for this PR?